Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Domain Transfer: Redirect from start to stepper #78948

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

escapemanuele
Copy link
Contributor

@escapemanuele escapemanuele commented Jul 4, 2023

Context

MERGE ONLY WHEN STEPPER BULK DOMAIN TRANSFER FLOW IS COMPLETED.

  • This PR redirects from /start/domain-transfer to /setup/domain-transfer, hence using the new domain-transfer flow built using Stepper
  • Removes the flow flag

Testing

  1. Live Link
  2. Visit /start/domain-transfer, you should land in /setup/domain-transfer

Fixes https://github.com/Automattic/dotcom-forge/issues/2926

@escapemanuele escapemanuele requested a review from a team July 4, 2023 15:24
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 4, 2023
@escapemanuele escapemanuele added Stepper and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 4, 2023
@escapemanuele escapemanuele self-assigned this Jul 4, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 4, 2023
@matticbot
Copy link
Contributor

matticbot commented Jul 4, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~20 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper        -61 B  (-0.0%)      -20 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@ebinnion
Copy link
Contributor

ebinnion commented Jul 7, 2023

I've already updated the buttons in the landing pages and there are existing issues in /start/domain-transfer, so I'm going to deploy this.

@ebinnion ebinnion merged commit b09d689 into trunk Jul 7, 2023
@ebinnion ebinnion deleted the bulk-domain-transfer/redirect branch July 7, 2023 13:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants