Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the “Live Preview” button on the Theme Detail page #79775
Add the “Live Preview” button on the Theme Detail page #79775
Changes from all commits
1595bfc
865a7ef
c1c9317
c0a84a6
abbfc19
5e9cd06
7e5bdf0
5ccfb76
38741b0
4861010
78d709e
ad9376f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not use
showTryAndCustomize
here asshowTryAndCustomize = true
does not mean it's not FullSiteEditing compatible. I thought it'd be nice to show the Live Preview button anytime in cases Block Theme Previews is available.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to account for Atomic site here? Or just Simple sites? Asking because the theme slugs on Atomic sites probably won't be prefixed with
/pub
or/premium
CMIIWThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stylesheet
includes prefixes (pub/
,premium/
) even on Atomic sites!This is the reason I switch
themePath
depending on if it's Atomic or Simple here. https://github.com/Automattic/wp-calypso/pull/79775/files/ac6c6b80c7ed9a71ab8d736db5254a1e8ce4eceb#diff-6535b936322e5679c10cdf1adeac00cda6c355312582892d7a634c4e2d6fbd64R120-R124Let me know if I did not answer your comment 🙏