Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Live Preview related code into TypeScript #80301

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Aug 8, 2023

Related to #80089, #79219, #79218

Proposed Changes

  • Convert Live Preview related code into TS!

Testing Instructions

i

  • Go to the Theme Showcase page.
  • Click three-dot on a free theme.
  • See if clicking the "Live Preview" option redirects you to the Site Editor (Block Theme Previews).

ii

  • Go to the Theme Detail page of a free theme.
  • See if clicking the "Live Preview" option redirects you to the Site Editor (Block Theme Previews).

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

@okmttdhr okmttdhr self-assigned this Aug 8, 2023
@okmttdhr okmttdhr changed the title TSify Live Preview related code Convert Live Preview related code into TS Aug 8, 2023
@okmttdhr okmttdhr changed the title Convert Live Preview related code into TS Convert Live Preview related code into TypeScript Aug 8, 2023
@okmttdhr okmttdhr marked this pull request as ready for review August 8, 2023 02:24
@okmttdhr okmttdhr requested a review from a team August 8, 2023 02:24
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 8, 2023
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr requested a review from a team August 8, 2023 02:36
Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@okmttdhr okmttdhr merged commit 4aacf36 into trunk Aug 8, 2023
4 checks passed
@okmttdhr okmttdhr deleted the update/live-preview-ts branch August 8, 2023 02:48
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants