-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track canvas mode changes in the Site Editor #81335
Conversation
This PR modifies the release build for wpcom-block-editor To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-l4k-p2 |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
apps/wpcom-block-editor/src/wpcom/features/tracking/site-editor-load.tsx
Outdated
Show resolved
Hide resolved
6aae601
to
205fb2d
Compare
205fb2d
to
cd1c44a
Compare
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Related to https://github.com/Automattic/dotcom-forge/issues/3301
Proposed Changes
I added the sidebar click events on the Site Editor in #80953. This PR tracks events when the "canvas" is clicked, as well as navigation clicks. This is because users can start editing without clicking on the navigation, and we want to track that point.
Alternatives I did not go for
setCanvasMode
is private API andunlock
function override JS object somehow..edit-site-layout__canvas-container
); This might not be exactly the same as canvas mode changes.Testing Instructions
cd apps/wpcom-block-editor/ && yarn dev --sync
Pre-merge Checklist