Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: Remove fallback translations for line item sublabels #81592

Merged

Conversation

sirbrillig
Copy link
Member

Proposed Changes

This is a follow-up to #80987 to remove the fallback translations now that the full translations are complete.

Testing Instructions

None should be required as this just removes fallbacks.

@sirbrillig sirbrillig requested a review from a team as a code owner September 11, 2023 14:14
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 11, 2023
@sirbrillig sirbrillig self-assigned this Sep 11, 2023
@matticbot
Copy link
Contributor

matticbot commented Sep 11, 2023

@sirbrillig sirbrillig added the [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. label Sep 11, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~106 bytes removed 📉 [gzipped])

name                               parsed_size           gzip_size
plans                                   -749 B  (-0.1%)     -106 B  (-0.0%)
jetpack-connect                         -749 B  (-0.1%)     -106 B  (-0.0%)
jetpack-cloud-pricing                   -749 B  (-0.1%)     -106 B  (-0.1%)
jetpack-cloud-plugin-management         -749 B  (-0.1%)     -106 B  (-0.0%)
jetpack-cloud-partner-portal            -749 B  (-0.1%)     -106 B  (-0.1%)
jetpack-cloud-features-comparison       -749 B  (-0.1%)     -106 B  (-0.1%)
jetpack-cloud-agency-dashboard          -749 B  (-0.1%)     -106 B  (-0.0%)
checkout                                -749 B  (-0.0%)     -106 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~106 bytes removed 📉 [gzipped])

name                                              parsed_size           gzip_size
async-load-masterbar-cart-masterbar-cart-wrapper       -749 B  (-0.8%)     -106 B  (-0.4%)
async-load-calypso-my-sites-checkout-modal             -749 B  (-0.1%)     -106 B  (-0.0%)
async-load-calypso-blocks-editor-checkout-modal        -749 B  (-0.1%)     -106 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirbrillig sirbrillig merged commit 4d8d10c into trunk Sep 11, 2023
6 of 7 checks passed
@sirbrillig sirbrillig deleted the remove/fallback-translations-checkout-line-item-sublabel branch September 11, 2023 14:30
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants