Removes CSS %container @extends as they were only used once. Also @ex… #8389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelArestad
added
the
[Type] Bug
MichaelArestad
added
the
[Status] Needs Review
|
Thanks! |
|
Needs conflict resolved... |
mtias
added
[Type] Janitorial
and removed
[Type] Bug
MichaelArestad
force-pushed
the
remove/container-extend
branch
from
140a7b1 to
cefdf3a
Compare
|
@lancewillett ready for review. |
|
🚢 LGTM Before/after screenshots in Firefox stable on OS X 10.12.1.
|
lancewillett
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, @extends are bad. There should be no visual changes.
I'm not sure how to test this one. It's used on the posts and welcome page according to the sass comment, but I think it's only used once in the NUX.