-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render Global Style notice only when necessary #84799
Conversation
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM 👍
Related to #84676, #79223
Proposed Changes
Currently, there's unnecessary DOM by Global Style notice even when the user is not using Global Style. This PR changes to render Global Style notice only when it is in use.
While this change appears trivial, I expect it to reduce the complexity when we add the new notice in the same place (See #84676). I'll create the follow-up PR to ensure showing only one notice simultaneously.
Testing Instructions
install-plugin.sh editing-toolkit fix/gs-notice
on your sandboxAppearance > Editor
(https:///wp-admin/site-editor.php)document.querySelector('.wpcom-global-styles-notice-container')
returns null)Style
navigationcalypso_global_styles_gating_notice_view_canvas_show
)On Atomic sites, we don't show the Global Style notice. You can test that breaks nothing, too, by downloading/uploading the plugin .zip file from TeamCity PCYsg-ly5-p2#atomic-testing.
Pre-merge Checklist