Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Global Style notice only when necessary #84799

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Dec 4, 2023

Related to #84676, #79223

Proposed Changes

Currently, there's unnecessary DOM by Global Style notice even when the user is not using Global Style. This PR changes to render Global Style notice only when it is in use.

While this change appears trivial, I expect it to reduce the complexity when we add the new notice in the same place (See #84676). I'll create the follow-up PR to ensure showing only one notice simultaneously.

before after
Screenshot 2023-12-04 at 15 35 56 Screenshot 2023-12-04 at 15 33 11 Screenshot 2023-12-04 at 16 08 20 Screenshot 2023-12-04 at 16 08 27

Testing Instructions

  • Run install-plugin.sh editing-toolkit fix/gs-notice on your sandbox
  • Prepare a free site
  • Sandbox your site
  • Go to Appearance > Editor (https:///wp-admin/site-editor.php)
  • Confirm it does not render Global Style notice when Global Style is NOT in use (e.g., See document.querySelector('.wpcom-global-styles-notice-container') returns null)
  • Add custom styles from the Style navigation
  • Confirm it shows Global Style notice
  • Confirm it sends the tracking event (calypso_global_styles_gating_notice_view_canvas_show)
  • Undo your change in Global Style
  • Confirm it does not render Global Style notice

On Atomic sites, we don't show the Global Style notice. You can test that breaks nothing, too, by downloading/uploading the plugin .zip file from TeamCity PCYsg-ly5-p2#atomic-testing.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Copy link

github-actions bot commented Dec 4, 2023

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • editing-toolkit

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/gs-notice on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr marked this pull request as ready for review December 4, 2023 07:14
@okmttdhr okmttdhr requested review from a team December 4, 2023 07:19
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 4, 2023
@okmttdhr okmttdhr self-assigned this Dec 4, 2023
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM 👍

@okmttdhr okmttdhr merged commit 074ea04 into trunk Dec 5, 2023
20 of 21 checks passed
@okmttdhr okmttdhr deleted the fix/gs-notice branch December 5, 2023 05:46
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants