Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect padding on the ThemeUpgradeModal #85346

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Dec 15, 2023

Related to #85013

Proposed Changes

This PR addresses a regression in the ThemeUpgradeModal, which was introduced in #85013. It fixes padding on the close icon by resetting the style from components.

before after
Screenshot 2023-12-15 at 16 25 24 Screenshot 2023-12-15 at 16 21 49

Testing Instructions

  • Prepare a Free site
  • Go to /setup/site-setup/designSetup?siteSlug=<your-site>
  • Pick a Premium theme
  • Click Unlock theme
  • Verify padding is correct

I also confirmed there is no regression on the Live Preview Upgrade modal.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Copy link

github-actions bot commented Dec 15, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr marked this pull request as ready for review December 15, 2023 07:33
@okmttdhr okmttdhr requested a review from a team December 15, 2023 07:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 15, 2023
@okmttdhr okmttdhr self-assigned this Dec 15, 2023
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/theme-upgrade-modal-close-icon on your sandbox.

Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Screenshot 2023-12-15 at 3 41 28 PM

@okmttdhr okmttdhr merged commit 9efedd9 into trunk Dec 15, 2023
18 of 19 checks passed
@okmttdhr okmttdhr deleted the fix/theme-upgrade-modal-close-icon branch December 15, 2023 07:42
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants