Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various E2E tests for recent Gutenberg changes #86070

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jan 5, 2024

Proposed Changes

Testing Instructions

  • Run tests, see if they pass now.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

* WordPress/gutenberg#56921 changed the label of the preview button from
  "Preview" to "View".
* WordPress/gutenberg#56904 removed the setting of an `is-xxx-preview`
  class when using the in-page preview. Targeting the parent element
  (that has a static class) instead.
* #86033 attempted to fix a test for another Gutenberg change, but the
  selector used there matches multiple elements in one of our tests and
  so causes it to fail. Adding `[role="tab"]` into the selector fixes
  that.
@anomiex anomiex requested review from sdixon194 and a team January 5, 2024 19:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sdixon194 sdixon194 merged commit 4631b99 into trunk Jan 5, 2024
14 checks passed
@sdixon194 sdixon194 deleted the fix/jetpack-e2e-tests branch January 5, 2024 21:02
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants