Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Preview: Add the contenthash to the chunk file to resolve the cache issue #86691

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Live Preview: Add the contenthash to the chunk file to resolve the cache issue #86691

merged 1 commit into from
Jan 24, 2024

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Jan 22, 2024 •
edited
Loading

Related to p1705634123164899-slack-C048CUFRGFQ

Proposed Changes

  • Add the contenthash (should we use [hash] to make sure it changes on every deploy?) to the chunk file to resolve the cache issue
Filename
Before wpcom-live-preview-notice.js
After wpcom-live-preview-notice-123c979e797142ab4bcf.js

Testing Instructions

  • Sandbox widgets.wp.com
  • Apply changes to your sandbox
  • Go to Theme Showcase on your site
  • Preview a theme
  • Check the Network request
  • Make sure the wpcom-live-preview-notice.js is loaded with the contenthash
    image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@arthur791004 arthur791004 self-assigned this Jan 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-95449
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-95449&env=jetpack

@arthur791004 arthur791004 requested a review from a team January 22, 2024 08:37
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 22, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/wpcom-block-editor-live-preview-cache on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

taipeicoder
taipeicoder approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge APAC tomorrow morning just in case 😅
Screenshot 2024-01-22 at 5 40 38 PM

@taipeicoder taipeicoder mentioned this pull request Jan 22, 2024
Closed
@okmttdhr
Copy link
Member

okmttdhr commented Jan 24, 2024 •
edited
Loading

I'm merging this PR!
p1706040808579779-slack-C02FMH4G8

@okmttdhr okmttdhr merged commit e563438 into trunk Jan 24, 2024
17 of 20 checks passed
@okmttdhr okmttdhr deleted the fix/wpcom-block-editor-live-preview-cache branch January 24, 2024 02:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 24, 2024
@fushar
Copy link
Contributor

fushar commented Jan 24, 2024

Thanks! I've double checked it works properly on Atomic sites too.

@okmttdhr
Copy link
Member

Shipped via D135707-code

@arthur791004
Copy link
Contributor Author

Thank you for deploying this 👍

@fushar fushar mentioned this pull request Jan 30, 2024
Merged
7 tasks
jjchrisdiehl pushed a commit that referenced this pull request Feb 5, 2024
@arthur791004 @jjchrisdiehl
Live Preview: Add the contenthash to the chunk file to resolve the ca…
9d431c7 
…che issue (#86691)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fushar fushar fushar approved these changes

@taipeicoder taipeicoder taipeicoder approved these changes

Assignees

@arthur791004 arthur791004

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arthur791004 @matticbot @okmttdhr @fushar @taipeicoder