Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Preview: Remove the redundant tooltip #87617

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Feb 20, 2024

Related to #

Proposed Changes

This PR removes the tooltip initially added for accessibility purposes. Given that its purpose overlaps with the button, we think it might be beneficial to remove this tooltip to avoid confusion temporarily. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role#accessibility_concerns

We'll explore alternative ways to display the shortcut key when we have the bandwidth. #87619

The accessibility tree:
Screenshot 2024-02-20 at 11 01 17

Related:
#85013 (comment)
#87584 (comment)

Testing Instructions

  • Patch this PR
  • Sandbox your site and widgets.wp.com
  • Prepare a free site
  • Live-preview a premium plan
  • Mouseover the Upgrade button
before after
Screenshot 2024-02-20 at 11 12 40 Screenshot 2024-02-20 at 11 10 13

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented Feb 20, 2024

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/live-preview-remove-tooltip on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr marked this pull request as ready for review February 20, 2024 02:11
@okmttdhr okmttdhr requested a review from a team February 20, 2024 02:11
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 20, 2024
@okmttdhr okmttdhr self-assigned this Feb 20, 2024
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@okmttdhr okmttdhr merged commit 6383c6b into trunk Feb 20, 2024
20 checks passed
@okmttdhr okmttdhr deleted the update/live-preview-remove-tooltip branch February 20, 2024 05:34
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants