Reader: Increase stream width #8792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jancavan
added
[Type] Enhancement
blowery
reviewed
Oct 17, 2016
| @@ -1,5 +1,9 @@ | |||
| // Reader-specific tweaks to components | |||
|
|
|||
| .following.main { | |||
There was a problem hiding this comment.
this should be scoped with .is-reader-page to keep it from affecting the current full post view
|
I think this is a great improvement for the wider screened set. 830px / 250px feels good to me. |
|
Turned on For testing purposes only. Note to self: do not merge! |
jancavan
added
[Status] In Progress
and removed
[Status] Needs Review
jancavan
added
[Status] Needs Review
blowery
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
🐑 LGTM |
This was referenced Oct 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a try branch to address: #8732
Default 720px (with 250px featured image):
A few other widths I tried:
800px (250px featured image):
830px (250px featured image):
850px (300px featured image):
@fraying I think either 800 or 830 is good. 850 is actually good too for cards with featured images, it's just a bit wide for excerpt-only ones.
This branch's link only has 850 to test so I included screenshots for other widths. I also just applied the width increase to the Following stream.