Themes: Leave the thanks modal's Visit Site button disabled until theme #8842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwight
added
[Feature Group] Appearance & Themes
|
Tested on Chrome. Design wise I think it's good 👍 |
|
👍 |
budzanowski
added
[Status] Ready to Merge
and removed
[Status] Needs Review
ockham
reviewed
Oct 19, 2016
| @@ -44,6 +44,10 @@ const ThanksModal = React.createClass( { | |||
| page( this.props.site.URL ); | |||
| }, | |||
|
|
|||
| visitSiteDisabled() { | |||
| return this.props.hasActivated ? false : true; | |||
There was a problem hiding this comment.
Can't we just
return ! this.props.hasActivated;(and maybe even inline that expression instead of having a method for it?)
There was a problem hiding this comment.
I just like the fact that method name explains its usage in this place.
|
@ockham Sure, I'll buy that; it's simple enough to grok, and unlikely to ever expand into needing a proper method. |
kwight
added
[Status] Needs Review
ockham
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
|
switch is complete. This will also give a few more moments for Headstart processes to complete.
kwight
force-pushed
the
update/thanks-modal-button
branch
from
5b71bea to
527a2b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch is complete.
This will also give a few more moments for Headstart processes to complete.
Before:
After:
Testing
/designand activate a new theme.