Pressable: show proper my-plan page #8847

artpi · 2016-10-19T09:40:42Z

This is a part of #8836.

Introduces state.sites.ID.options.pressable option in sites redux tree
Introduces isPressableSite selector
Introduces PRESSABLE_TRANSFER_SUCCESS action to test pressable internals
Disables domains manage link in my-plan page

Testing

Go to my-plan page for a business site
Open redux dispatcher from redux devtools
Dispatch { type: 'PRESSABLE_TRANSFER_SUCCESS', siteId: ID }
See that button disappears for managing domain OR whole call to action disappears for using domain credit

CC @rralian @gwwar @lamosty @retrofox @adambbecker

matticbot · 2016-10-19T09:40:43Z

Test live: https://calypso.live/?branch=experiment/pressable-my-plan

rralian · 2016-10-19T13:59:54Z

FAQ

EDIT: @artpi - I moved the questions here from the thread main post:

How are you going to use your domain credit while on this plan? Do we implement domain management?
Should we show "Advertising removed" section? Does not make sense for jetpack, but its still continuing features from previous plans
Is the .com theme catalogue going to be hooked up ? For jetpack sites we currently show only installed themes
What about wordads instant activation? Is that going to be present in pressable?

How are you going to use your domain credit while on this plan? Do we implement domain management?

I've been discussing this a bit with @p3ob7o. No promises, but we may be able to enable domain management for these sites. In practice most users will not have a domain credit because automated-transfer will be limited to users with a custom domain. But it's possible for a business site to have a custom domain and still have an available domain credit, so we still need to work this out.

Should we show "Advertising removed" section? Does not make sense for jetpack, but its still continuing features from previous plans

Yes. These are dotcom business site users who have made use of the custom theme/plugin functionality. Jetpack is an implementation detail that isn't relevant to the user.

Is the .com theme catalogue going to be hooked up ? For jetpack sites we currently show only installed themes

Yes, that is the plan. See the spreadsheet which links back to the master thread for that effort.

What about wordads instant activation? Is that going to be present in pressable?

It should, yes. There's work involved there too though.

gwwar · 2016-10-19T16:36:40Z

client/blocks/product-purchase-features/product-purchase-features-list/custom-domain.jsx

-				selectedSite={ selectedSite }
-				hasDomainCredit={ hasDomainCredit }
-			/>
+			<CustomDomainPurchaseDetail { ...pick( props, [ 'selectedSite', 'hasDomainCredit', 'isPressableSite' ] ) } />


I actually think the former is more readable but ¯_(ツ)_/¯

Me too. I think we should pass all the props (with picking/omitting some) only if they are passed to a native component like div or button. Those component can accept various different props so it's better to simply pass down everything instead of listing the possible props.

However, in this case, we are passing down only three props so it's unnecessary to use this pattern IMO. :)

For each of these props it was repeating each prop name ( selectedSite for example) 3 times just to pass it down.
Each of these repeats compounds the likelihood of making an error when adding/removing/modfing passed prop.
I refactored it not because of readability, but because of DRY

gwwar · 2016-10-19T16:41:05Z

client/state/sites/selectors.js

+		return null;
+	}
+
+	return site.options.pressable;


👍 Thanks for adding this. Let's check in with @peterbutler as work starts on this.

I checked in with Peter and he is completely ok with that. Looks like pressable plan will be just a regular business plan.
I think this can be a good selector to make work on this easier.
Worse case scenario, we can remove it later, but even having something to grep can be a good start

gwwar · 2016-10-26T18:22:25Z

client/state/sites/reducer.js

+			const originalSite = state[ action.siteId ];
+			if ( originalSite ) {
+				return Object.assign( {}, state, {
+					[ action.siteId ]: merge( {}, originalSite, { jetpack: true, options: { pressable: true } } )


This is a good start, but we'll probably also want to mark when a site is in the process of transferring.

gwwar · 2016-10-26T18:28:20Z

client/my-sites/upgrades/checkout-thank-you/custom-domain-purchase-detail.jsx

-		<PurchaseDetail
+		);
+	} else if ( ! hasDomainCredit && hasCustomDomain( selectedSite ) ) {
+		const actionButton = {};


The name here makes it sound like this is a component instead of a grouping of props. Perhaps we should refactor PurchaseDetail a bit.

A ternary might be a better fit, though the usage is still a bit odd.

const purchaseDetailButtonProps = isPressableSite ? {} : { buttonText: translate( 'Manage my domains' ), href: `/domains/manage/${ selectedSite.slug }` };

gwwar · 2016-10-26T18:29:16Z

client/my-sites/upgrades/checkout-thank-you/custom-domain-purchase-detail.jsx

-			return renderHasCustomDomain();
-		}
-
+			{ ...actionButton }


I'm thinking it might make sense to update purchase detail to accept child components, and remove the PurchaseButton wrapper. (which only adds a class to button and is unnecessary ).

If this feels out of scope, lets mark this for another janitorial

gwwar · 2016-10-26T18:38:07Z

client/state/sites/reducer.js

@@ -75,6 +75,15 @@ export function items( state = {}, action ) {
 			}
 			return state;

+		case 'PRESSABLE_TEST':


The name of this would more likely be something closer to PRESSIBLE_TRANSFER_START. Do you mind adding a new action type, even though we might rename this later.

gwwar · 2016-10-26T19:07:19Z

I left a few notes, but I think we can merge this in after creating a proper action type.

artpi · 2016-10-27T01:05:06Z

After @gwwar pointers, I:

Introduced 2 selectors ( isPressableSite and isPressableSiteInTransfer )
Introduced 2 actions:PRESSABLE_TRANSFER_SUCCESS and PRESSABLE_TRANSFER_START

Introduce 2 selectors ( isPressableSite and isPressableSiteInTransfer ) to easily detect the state of pressable transfer and if site is in fact on pressable Also hide "manage domain" button * Add groundwork for marking site pressable * Pass on pressable site status * Introduce review pointers * Make constants ssr-ready so test pass

artpi added [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 19, 2016

artpi added this to the Plans: Maintenance milestone Oct 19, 2016

artpi self-assigned this Oct 19, 2016

gwwar reviewed Oct 19, 2016

View reviewed changes

artpi added 2 commits October 26, 2016 10:43

Add groundwork for marking site pressable

e85a50c

Pass on pressable site status

6ac97f6

artpi force-pushed the experiment/pressable-my-plan branch from 83e53fb to 6ac97f6 Compare October 26, 2016 16:01

artpi mentioned this pull request Oct 26, 2016

Plans: AT Business Users should see a WPCOM Business plan on my-plan page #8836

Closed

artpi removed the [Status] In Progress label Oct 26, 2016

gwwar added the [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. label Oct 26, 2016

gwwar reviewed Oct 26, 2016

View reviewed changes

Introduce review pointers

e4321c8

Make constants ssr-ready so test pass

13366ff

artpi merged commit e7bd8c6 into master Oct 27, 2016

artpi deleted the experiment/pressable-my-plan branch October 27, 2016 01:31

lancewillett removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 27, 2016

snyk-bot mentioned this pull request Mar 7, 2020

[Snyk] Security upgrade jest-config from 24.9.0 to 25.0.0 awaisab172/wp-calypso#8

Open

snyk-bot mentioned this pull request Mar 30, 2021

[Snyk] Fix for 1 vulnerabilities awaisab172/wp-calypso#65

Open

snyk-bot mentioned this pull request May 27, 2021

[Snyk] Security upgrade jest-config from 24.9.0 to 25.0.0 awaisab172/wp-calypso#77

Open

snyk-bot mentioned this pull request Sep 16, 2021

[Snyk] Fix for 1 vulnerabilities awaisab172/wp-calypso#97

Open

awaisab172 mentioned this pull request Jun 21, 2023

[Snyk] Fix for 1 vulnerabilities awaisab172/wp-calypso#152

Open

awaisab172 mentioned this pull request May 23, 2024

[Snyk] Fix for 2 vulnerabilities awaisab172/wp-calypso#199

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pressable: show proper my-plan page #8847

Pressable: show proper my-plan page #8847

artpi commented Oct 19, 2016 •

edited

Loading

matticbot commented Oct 19, 2016

rralian commented Oct 19, 2016 •

edited by artpi

Loading

gwwar Oct 19, 2016

lamosty Oct 24, 2016

artpi Oct 26, 2016 •

edited

Loading

gwwar Oct 19, 2016

artpi Oct 26, 2016

gwwar Oct 26, 2016

gwwar Oct 26, 2016

gwwar Oct 26, 2016

gwwar Oct 26, 2016

gwwar Oct 26, 2016

gwwar commented Oct 26, 2016

artpi commented Oct 27, 2016

Pressable: show proper my-plan page #8847

Pressable: show proper my-plan page #8847

Conversation

artpi commented Oct 19, 2016 • edited Loading

Testing

matticbot commented Oct 19, 2016

rralian commented Oct 19, 2016 • edited by artpi Loading

FAQ

Choose a reason for hiding this comment

Choose a reason for hiding this comment

artpi Oct 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gwwar commented Oct 26, 2016

artpi commented Oct 27, 2016

artpi commented Oct 19, 2016 •

edited

Loading

rralian commented Oct 19, 2016 •

edited by artpi

Loading

artpi Oct 26, 2016 •

edited

Loading