Framework: use social-logos package #9399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
added
Framework
[Status] Needs Review
1 task
gwwar
force-pushed
the
try/social-logos
branch
from
2c473ce to
e4e55f9
Compare
lamosty
reviewed
Nov 16, 2016
| @@ -1,12 +1,12 @@ | |||
| Social Logo | |||
| ======== | |||
|
|
|||
| Component that renders a single socail-logo svg based on an `icon` prop. It takes a size property but defaults to 24px. For greater sharpness, the icons should only be shown at either 18, 24, 36 or 48px. There's a gallery with all the available icons in devdocs/design. | |||
There was a problem hiding this comment.
Could we maybe add a link to https://github.com/Automattic/social-logos in the README? I wouldn't know we are speaking about that package if I didn't see this PR.
Maybe just adding a link to the text: "...renders a single [social-logo](link here) svg based...".
There was a problem hiding this comment.
Sounds good 👍 I'll try to follow up in a later PR to show examples in devdocs directly from the package vs here.
retrofox
reviewed
Nov 16, 2016
| @@ -1,12 +1,12 @@ | |||
| Social Logo | |||
| ======== | |||
|
|
|||
| Component that renders a single socail-logo svg based on an `icon` prop. It takes a size property but defaults to 24px. For greater sharpness, the icons should only be shown at either 18, 24, 36 or 48px. There's a gallery with all the available icons in devdocs/design. | |||
| Component that renders a single social-logo svg based on an `icon` prop. It takes a size property but defaults to 24px. For greater sharpness, the icons should only be shown at either 18, 24, 36 or 48px. There's a gallery with all the available icons in devdocs/design. | |||
There was a problem hiding this comment.
stupid comment but should we add px to each size:
18px, 24px, 36px or 48px
There was a problem hiding this comment.
Thanks I'll add this to the social-logo readme
|
Nice work! LGTM 🚢. |
lamosty
added
[Status] Ready to Merge
and removed
[Status] Needs Review
gwwar
force-pushed
the
try/social-logos
branch
from
e4e55f9 to
dd30047
Compare
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually copying from https://github.com/Automattic/social-logos this PR pairs with Automattic/social-logos#42 to use it as an external dependency.
Note that this component assumes that
reactandclassnamesare available in the parent project.Misc changes have snuck into the Calypso SocialLogo file over time, so keep an eye out for any breakages. For example, using service names directly eg
google_plusand failing to transform the value into kebobCasegoogle-plusTesting
Tasks
cc @aduth @obenland @lamosty @retrofox