Reader Refresh: Use white background on the following/edit page #9415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowery
changed the title
samouri
force-pushed
the
add/reader/refresh-manage-mvp-whitification
branch
from
f837837 to
8b61664
Compare
samouri
added
[Status] Needs Review
bluefuton
changed the title
bluefuton
approved these changes
Nov 17, 2016
bluefuton
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement the MVP of the Manage Following page as described in #9143
It does two things:
While implementing the white background, I decided to add the
is-reader-pageclass toReaderMainso that during the refresh we don't need to duplicate the Main vs. ReaderMain logic in all of our newly-white-backgrounded changes.Screenshot of how it should look:
