Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VSCode performance by removing jsconfig.json #98071

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mehmoodak
Copy link
Member

Proposed Changes

Improve VS Code performance by removing jsconfig.json file.

Similar action has been taken in Gutenberg codebase to improve performance (WordPress/gutenberg#68347)

Why are these changes being made?

If you open the project in VS Code and open few files, you will see this warning:

image

Removing the file also helps to avoid conflicts between two config files.

Testing Instructions

  1. On trunk, open the project in VS Code
  2. Open following files and most probably you will see the "Configure Excludes" message.
    • client/blocks/reader-author-link/index.tsx
    • apps/blaze-dashboard/src/components/layout.jsx
    • client/devdocs/design/wordpress-components-gallery/snackbar.tsx
  3. Confirm that you see that above mentioned warning.
  4. Now, on this branch, reload VS Code Cmd/Ctrl + Shift + P > Developer: Reload Window
  5. Open the same files
  6. Confirm that there is no warning

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mehmoodak mehmoodak self-assigned this Jan 8, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@mehmoodak mehmoodak marked this pull request as ready for review January 8, 2025 09:03
@mehmoodak mehmoodak requested review from tyxla and a team January 8, 2025 09:04
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 8, 2025
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you 👍

@mehmoodak mehmoodak merged commit 558e97b into trunk Jan 8, 2025
14 of 15 checks passed
@mehmoodak mehmoodak deleted the improve/vs-code-performance-by-removing-js-config branch January 8, 2025 16:36
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants