Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

must not fail if MemCache class isn't available #159

Open
drzraf opened this issue Apr 16, 2024 · 0 comments · May be fixed by #164
Open

must not fail if MemCache class isn't available #159

drzraf opened this issue Apr 16, 2024 · 0 comments · May be fixed by #164

Comments

@drzraf
Copy link

drzraf commented Apr 16, 2024 •
edited
Loading

It can occur during a lot of situation:

  • enabled in FPM but not in CLI (so wp-cli fails): I guess it's shouldn't even load if PHP_SAPI === 'cli'
  • during a PHP socket switch / version upgrade
  • during a debugging attempt that imply deactivating so PHP modules
  • ...

In all these and others cases, the extensions should definitely NOT trigger a fatal error.
edneville added a commit to edneville/wp-memcached that referenced this issue Aug 1, 2024
@edneville
If memcache isn't present carry on
9a6e201 
Closes Automattic#159
@edneville edneville linked a pull request Aug 1, 2024 that will close this issue
Open
edneville added a commit to edneville/wp-memcached that referenced this issue Aug 2, 2024
@edneville
If memcache isn't present carry on
165d17e 
Simply return like as if there was no match on lookup and don't attempt
to add if there is no memcache class.

Closes Automattic#159
@edneville edneville mentioned this issue Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If memcache isn't present carry on edneville/wp-memcached
1 participant
@drzraf