Make sure updated $cache_path ends in '/' #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basename() removes the trailing slash, which is expected in the $cache_path variable / config file. Without this fix, you can enter /some/path/wp-content/cache/ and end up with /some/path/wp-content/cachesupercache/ , .../wp-content/cachemeta/ , etc. Also, don't bother updating the config file if the path hasn't changed.
|
Looks good to me. Going to get a second 👍. |
kraftbj
pushed a commit
that referenced
this pull request
Feb 9, 2017
* Make sure $cache_path has a trailing slash (#77) * Remove flush() (#127) but also check if headers are empty and flush and get headers again. (#179) * Add fix for customizer (#161) and don't cache PUT AND DELETE requests (#178) * Check for superglobals before using them. (#131) git-svn-id: http://plugins.svn.wordpress.org/wp-super-cache/trunk@1588365 b8457f37-d9ea-0310-8a92-e5e31aec5664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basename()removes the trailing slash, which is expected in the$cache_pathvariable / config file. Without this fix, you can enter /some/path/wp-content/cache/ and end up with /some/path/wp-content/cachesupercache/ , .../wp-content/cachemeta/ , etc.Also, don't bother updating the config file if the path hasn't changed.