Update debug package to 3.1.0 to get vulnerability fix #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
Should only be meaningful in development mode anyway. As long as we test this out I'm fine with it - thanks for the update.
We might want to change the wpcom-oauth-cors version to something like 1.0.2-beta and do a beta release on npm to make testing easier (if testing ends up more difficult)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
debughad a regexp denial of service fixed in 3.1.0 so this updates the package to obtain that fix.This fix is needed for another internal project.
This fix was introduced in debug-js/debug#504