Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf method for feedback #59

Merged

Conversation

v9n
Copy link
Member

@v9n v9n commented Dec 12, 2024

Fixed #42

Also standarize the List*.

Before

list wallet -> {wallets: [] }
list tasks -> {tasks: [], cursor }
list execs -> {executions: [], cursor }

After

list wallet -> {items: [] }
list tasks -> {items: [], cursor }
list execs -> {items: [], cursor }

Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* update error message on auth failure

* update error message
@v9n v9n merged commit e8dc6bb into continue-impl-for-other-node-execution Dec 12, 2024
4 checks passed
@v9n v9n deleted the update-proto-buf-for-feedback branch December 12, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants