Automation price poc #420

v9n · 2023-09-05T16:20:48Z

Automation pallet that trigger tasks based on price. Currently price is updated externally. More docs will come when this form into a runable state to explain the detail.

We organized the data structure into this tree:

[chain][exchange][asset1, asset2]: pricedata

Initialize asset

We can repeat this for many assets per that chain/exchange.

Example call 1

This example, we Initialize a pair for (DOT, USDT) on astar chain, artswap exchange. and also authorized "ALICE" wallet to update this asset price. In practice, "ALICE" should be updated to the wallet address of the oracle provider.

0xc8011461737461722061727468737761700c444f5410555344540604d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d

local polkadotjs decoded link

Example call 2

This example, we Initialize a pair for (KSM, USDC) on moonbeam chain, uniswap exchange. and also authorized "BOB" wallet to update this asset price

0xc801206d6f6f6e6265616d1c756e69737761700c4b534d10555344430604d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d

local polkadotjs decode link

Now we can inspect storage

Update price

Price can be update at the same time. It has these below argument

chains: list of chain
exchanges: list of exchange
assets1: list of asset1
assets2: list of asset2
prices: note the decimal to submit properly. only interger, not float
submittedAt: epoch at submission time.
rounds: an incremental value when submit price. We haven't used this parameter yet in our code base

Example we can update the price of 3 pairs

chains: [astar, astar, astar]
exchanges: [arthswap, arthswap, arthswap]
assets1: [ksm, tur, dot]
assets2: [tur, usdc, udsdt]
prices: [600, 6000, 3000]
submittedAt: [14243553252523,14243553252523,14243553252523,]
rounds: [200, 200, 200]

all the array obviously need to have the same length so we can construct the pair.

Example encoded call hash

Here we will update prices of 2 assets in a single extrinsic

0xc80208146173746172206d6f6f6e6265616d082061727468737761701c756e6973776170080c444f540c4b534d081055534454105553444308404b4c0000000000000000000000000080b14f0100000000000000000000000008d05c0abf8a010000000000000000000022170e65000000000000000000000000088403000000000000000000000000000057020000000000000000000000000000

polkadotjs decode link

now we can inspect the storage

Task Schedule

Very similar to automation time.

chain: target chain
exchange: exchange name
asset1: first asset of the pair
asset2: second asset of the pair
expiredAt: if task has not executed after this, they will be removed
triggerFunction: accept only 2 values for now
- gt
- lt
triggerParam: an array of argument to pass to trigger function. At this moment, we only need to pass a signle element, which is the target price to be trigger

In this example task will be trigger when the TUR/USDC price is >= 60000000(note the decimal of the asset pair)

Example call

This is a task that is trigger when KSM/USDT is worth 5.5USDT

0xc8051461737461722061727468737761700c444f54105553445430f8f01b92010000000000000000000008677404c0d6540000000000000000000000000003010100411f03010100411f03010100411f97b33c19460f0d000000000000000000d0120000d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d01000a073048656c6c6f20776f726c6421ee59452a8949037b7efcf88a491000d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d

polkadotjs decode link

Chain Storage

These can be used to evaluate the storage

AssetRegistry: contains asset and pair metadata info, immediately created when initialize an asset
PriceRegistry: contains the lastest data only of asset price

For task insertion, it's stored in:

Tasks: hashmap of task id -> task data
SortedTasksIndex: hashmap of (chain, exchange, (asset1, asset2), trigger_function) -> BTreeMap(<price-target, [task_id])>
TaskQueue: Active task to be executed.
AccountTasks

imstar15 · 2023-09-12T12:33:51Z

pallets/automation-price/src/lib.rs

+			assets2: Vec<AssetName>,
+			prices: Vec<AssetPrice>,
+			submitted_at: Vec<u128>,
+			rounds: Vec<u128>,


Please add comments to explain the purpose of this function and its parameters.

Hi @imstar15

I had added the parameter document. On the PR link I also added encoded call data so one can click and decode

chrisli30

The existing code looks well organized so far.

chrisli30 · 2023-09-21T00:54:51Z

pallets/automation-price/src/lib.rs

@@ -260,8 +363,7 @@ pub mod pallet {
 		LiquidityRestrictions,
 		/// Too Many Assets Created
 		AssetLimitReached,
-		/// Direction Not Supported
-		DirectionNotSupported,
+		BadVersion,


Other error code are self-explanatory but this BadVersion needs some comments.

comment is added

pallets/automation-price/src/lib.rs

chrisli30 · 2023-09-23T00:12:16Z

The trigger worked! I was able to see the task inserted into the automationPrice.accountTasks and to trigger it with a price movement. One feedback is that we should emit a automationPrice.AssetUpdated event during update (there is an automationPrice.AssetCreated for creation).

Encoded call on Turing - WRSTR, USDT, lt, 100
0xc8051c736869627579612061727468737761701457525354521055534454d52a0e65000000000000000000000000086c74046400000000000000000000000000000003010100411f03010100411f03010100411f2b857121f64f13000000000000000000d0120000d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d01000a073048656c6c6f20776f726c6421ee59452a8949077b123270018a491800d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d

Task is inserted into AccountTask

Price fetch history from Turing’s PriceRegistry

Events triggered by price movement from 200 to 80

chrisli30 · 2023-09-23T00:19:21Z

The end result should be a ethereumChecked.transact event on Shibuya/Rocstar, but since I didn’t have an EVM smart contract set up locally I used system.remarkWithEvent.

Eventually, we should see three events in order.

ethereumChecked.transact
proxy.proxyExecuted
xcmQueue.success

An un-optimization pallet to enable an oracle price feed, price update, task scheduling based on price and task triggering based on asset price compartion with target price The weight is hardcode, document is still lack off and data structure is still being finalized.

v9n · 2023-09-25T21:09:31Z

Hi @chrisli30 @imstar15

Please give a final round of review. There are still many optimization we can do but we would like to merge this, have it run with the xcm-demo-price app and iterate.

Pending items I will need to address next is keep track in this issue: #434

chrisli30

No major changes from my last review, so I believe that this is good enough to merge. I left one more minor comment though.

chrisli30 · 2023-09-26T04:01:38Z

pallets/automation-price/src/tests.rs

@@ -417,7 +416,7 @@ fn test_shift_tasks_movement_through_price_changes() {

 		let task_ids = get_task_ids_from_events();
 		let task_id1 = task_ids.get(task_ids.len().wrapping_sub(3)).unwrap();
-		let task_id2 = task_ids.get(task_ids.len().wrapping_sub(2)).unwrap();
+		let _task_id2 = task_ids.get(task_ids.len().wrapping_sub(2)).unwrap();


Should the format of these task_id variable names be consistent?

Lalsha40 · 2024-03-18T14:22:19Z

I need pr no

imp1ssible23 · 2024-03-18T15:18:08Z

What I want is that “hash of the first commit that was ever made to the main oak GitHub repo”, help me with that please if possible but I am not sure if I know the pr no. It must be very first. Thank you Regards Sent from Yahoo Mail for iPhone On Monday, March 18, 2024, 8:07 PM, Lalsha40 ***@***.***> wrote: I need pr no — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

v9n changed the title ~~Automation price poc~~ [wip]Automation price poc Sep 5, 2023

v9n marked this pull request as draft September 5, 2023 16:24

v9n force-pushed the automation-price-poc branch 3 times, most recently from 98fce28 to 5e56b96 Compare September 8, 2023 17:14

imstar15 reviewed Sep 12, 2023

View reviewed changes

v9n force-pushed the automation-price-poc branch 5 times, most recently from cf31683 to df4e8d8 Compare September 18, 2023 01:32

v9n added the enhancement New feature or request label Sep 18, 2023

v9n self-assigned this Sep 18, 2023

v9n added the WIP work in progress, not ready for review label Sep 18, 2023

v9n force-pushed the automation-price-poc branch from 57a851a to e4986d4 Compare September 18, 2023 02:53

chrisli30 reviewed Sep 21, 2023

View reviewed changes

v9n force-pushed the automation-price-poc branch from d0cbc1c to 58c07c0 Compare September 22, 2023 02:16

v9n force-pushed the automation-price-poc branch from ef4c861 to aaa6260 Compare September 25, 2023 19:31

v9n added 2 commits September 25, 2023 13:33

add comment

0bbfe17

code formar

359395a

v9n changed the title ~~[wip]Automation price poc~~ Automation price poc Sep 25, 2023

v9n mentioned this pull request Sep 25, 2023

Price Triggering #434

Closed

11 tasks

remove dead code

1b960bf

v9n marked this pull request as ready for review September 26, 2023 01:42

chrisli30 approved these changes Sep 26, 2023

View reviewed changes

remove dead code

4ff9ab3

oak-code-formatter and others added 2 commits September 26, 2023 18:49

fixup: auto format Rust code

3d45397

remove dead code

ad4bddf

v9n merged commit b6187fc into master Sep 26, 2023

v9n deleted the automation-price-poc branch September 26, 2023 20:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automation price poc #420

Automation price poc #420

v9n commented Sep 5, 2023 •

edited

Loading

imstar15 Sep 12, 2023

v9n Sep 25, 2023

chrisli30 left a comment

chrisli30 Sep 21, 2023 •

edited

Loading

v9n Sep 25, 2023

chrisli30 commented Sep 23, 2023 •

edited

Loading

chrisli30 commented Sep 23, 2023

v9n commented Sep 25, 2023 •

edited

Loading

chrisli30 left a comment

chrisli30 Sep 26, 2023

Lalsha40 commented Mar 18, 2024

imp1ssible23 commented Mar 18, 2024 via email

Automation price poc #420

Automation price poc #420

Conversation

v9n commented Sep 5, 2023 • edited Loading

Initialize asset

Example call 1

Example call 2

Update price

Example encoded call hash

Task Schedule

Example call

Chain Storage

imstar15 Sep 12, 2023

Choose a reason for hiding this comment

v9n Sep 25, 2023

Choose a reason for hiding this comment

chrisli30 left a comment

Choose a reason for hiding this comment

chrisli30 Sep 21, 2023 • edited Loading

Choose a reason for hiding this comment

v9n Sep 25, 2023

Choose a reason for hiding this comment

chrisli30 commented Sep 23, 2023 • edited Loading

chrisli30 commented Sep 23, 2023

v9n commented Sep 25, 2023 • edited Loading

chrisli30 left a comment

Choose a reason for hiding this comment

chrisli30 Sep 26, 2023

Choose a reason for hiding this comment

Lalsha40 commented Mar 18, 2024

imp1ssible23 commented Mar 18, 2024 via email

v9n commented Sep 5, 2023 •

edited

Loading

chrisli30 Sep 21, 2023 •

edited

Loading

chrisli30 commented Sep 23, 2023 •

edited

Loading

v9n commented Sep 25, 2023 •

edited

Loading