Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspect node compiler #476

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Inspect node compiler #476

merged 6 commits into from
Dec 13, 2023

Conversation

v9n
Copy link
Member

@v9n v9n commented Dec 4, 2023

Inspect our glibc and log the glibc the binary used to prevent the case where our binary get update due to OS update and we shorted sighted.

ref #475

@v9n v9n force-pushed the inspect-node-compiler branch from ad9991f to 7e668cb Compare December 4, 2023 20:51
@v9n v9n force-pushed the inspect-node-compiler branch from 7e668cb to f3480bb Compare December 4, 2023 20:53
@v9n v9n requested review from chrisli30 and imstar15 December 4, 2023 20:54
chrisli30
chrisli30 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay nice, this objdump command will display the version that this binary is using right?

It would be great to add a comment,

# For example, expected output is 2.30

chrisli30
chrisli30 reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this looks good!

@v9n v9n merged commit 88bab8d into master Dec 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisli30 chrisli30 chrisli30 approved these changes

@imstar15 imstar15 Awaiting requested review from imstar15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v9n @chrisli30