Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover JSON data in Data node control #1248

Open
4 tasks
EYisaac opened this issue May 1, 2024 · 21 comments · May be fixed by #2164
Open
4 tasks

Cover JSON data in Data node control #1248

EYisaac opened this issue May 1, 2024 · 21 comments · May be fixed by #2164
Assignees
Labels
Core Related to Taipy Core 🖰 GUI Related to GUI hacktoberfest - 300💎💎💎 Issues rewarded by 300 points hacktoberfest hacktoberfest issues 🆘 Help wanted Open to participation from the community ✨New feature 🟨 Priority: Medium Not blocking but should be addressed ⚔️ Quest Tracks quest-bot quests

Comments

@EYisaac
Copy link

EYisaac commented May 1, 2024

What would that feature address

I have some transactional data as json file representing a list of shops with various characteristics address, size, location, opening time, type, owner, contact, etc... The structure of the document is globally the same all the time, but time to time a new field appears, disappears or changes. I am using data node to keep track of the changes since it is edited by many people, and because I also have sql data nodes on the side.

I want to show the JSON data node in the data node control.

Description of the ideal solution
The ideal solution would be to have the possibility to collapse and expand recursively the various sections of the document. A syntax coloration or a visual hint could give the type of the field displayed like in the following example

image

{"web-app": {
  "servlet": [   
    {
      "servlet-name": "cofaxCDS",
      "servlet-class": "org.cofax.cds.CDSServlet",
      "init-param": {
        "configGlossary:installationAt": "Philadelphia, PA",
        "configGlossary:adminEmail": "ksm@pobox.com",
        "configGlossary:poweredBy": "Cofax",
        "configGlossary:poweredByIcon": "/images/cofax.gif",
        "dataStoreDriver": "com.microsoft.jdbc.sqlserver.SQLServerDriver",
        "dataStoreUrl": "jdbc:microsoft:sqlserver://LOCALHOST:1433;DatabaseName=goon",
        "dataStoreInitConns": 10,
        "dataStoreMaxConns": 100,
        "dataStoreConnUsageLimit": 100,
        "dataStoreLogLevel": "debug",
        "maxUrlLength": 500}},
    {
      "servlet-name": "cofaxEmail",
      "servlet-class": "org.cofax.cds.EmailServlet",
      "init-param": {
      "mailHost": "mail1",
      "mailHostOverride": "mail2"}},
    {
      "servlet-name": "cofaxAdmin",
      "servlet-class": "org.cofax.cds.AdminServlet"},
 
    {
      "servlet-name": "fileServlet",
      "servlet-class": "org.cofax.cds.FileServlet"},
    {
      "servlet-name": "cofaxTools",
      "servlet-class": "org.cofax.cms.CofaxToolsServlet",
      "init-param": {
        "templatePath": "toolstemplates/",
        "log": 1,
        "logLocation": "/usr/local/tomcat/logs/CofaxTools.log",

        "fileTransferFolder": "/usr/local/tomcat/webapps/content/fileTransferFolder",
        "lookInContext": 1,
        "adminGroupID": 4,
        "betaServer": true}}],
  "servlet-mapping": {
    "cofaxCDS": "/",
    "cofaxEmail": "/cofaxutil/aemail/*",
    "cofaxAdmin": "/admin/*",
    "fileServlet": "/static/*",
    "cofaxTools": "/tools/*"},
 
  "taglib": {
    "taglib-uri": "cofax.tld",
    "taglib-location": "/WEB-INF/tlds/cofax.tld"}}}

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%
  • Create related issue in taipy-doc for documentation and Release Notes
  • Check if a new demo could be provided based on this, or if legacy demos could be benefit from it
  • Ensure any change is well documented
@EYisaac
Copy link
Author

EYisaac commented May 1, 2024

@FlorianJacta FlorianJacta added Core Related to Taipy Core 🖰 GUI Related to GUI 🟨 Priority: Medium Not blocking but should be addressed labels May 2, 2024
@FlorianJacta
Copy link
Member

Thank you for the issue @EYisaac. This feature aligns with what the Data Node viewer aims to do.

You could also use the tree visual element to obtain this effect in the meantime.

@jrobinAV @FabienLelaquais what do you think about it?

@EYisaac
Copy link
Author

EYisaac commented May 3, 2024

I would prefer it to be in a data node control instead of a tree control. Especially for editing the content of the JSON file.
I guess I can use the tree if there is no other way.

@FlorianJacta
Copy link
Member

I agree! This is just a workaround in the meantime

@jrobinAV
Copy link
Member

It is a great idea. @FabienLelaquais Let's discuss this.

@jrobinAV jrobinAV added the 🔒 Staff only Can only be assigned to the Taipy R&D team label May 31, 2024
@jrobinAV
Copy link
Member

After discussing it, we plan to add it to the Enterprise edition.

@EYisaac
Copy link
Author

EYisaac commented Sep 16, 2024

Will it be in the next release?

@jrobinAV jrobinAV added 🆘 Help wanted Open to participation from the community hacktoberfest hacktoberfest issues hacktoberfest - 300💎💎💎 Issues rewarded by 300 points and removed 🔒 Staff only Can only be assigned to the Taipy R&D team labels Sep 25, 2024
@FlorianJacta
Copy link
Member

FlorianJacta commented Sep 27, 2024

Will it be in the next release?

This won't be in the next release that is going to be published in a few days. It is still an open issue.

@KunjShah95
Copy link

CAN U PLEASE ASSIGN IT TO EME AND REMOVE MY ALL PREVIOUS ASSIGNEED ONE

@FlorianJacta
Copy link
Member

@KunjShah95 You are assigned to this ticket! Thank you

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 7, 2024
Copy link

quest-bot bot commented Oct 7, 2024

New Quest! image New Quest!

A new Quest has been launched in @Avaiga’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #1248 to link your PR to this Quest.

Questions? Check out the docs.

@THEBOSS0369
Copy link
Contributor

THEBOSS0369 commented Oct 20, 2024

Hey @FlorianJacta ! Can i work on this issue ? I have completed my previous issue and it has been marked hacktoberfest-apporved here #2018 .

Also can you tell which file contains the logic for this issue.
Thanks

@FlorianJacta
Copy link
Member

Here you go @THEBOSS0369, you can work on it! I will not be able to tell you which files are to be changed. Maybe, @jrobinAV or @FredLL-Avaiga will help you on that

@THEBOSS0369
Copy link
Contributor

@quest-bot embark

Copy link

quest-bot bot commented Oct 26, 2024

@THEBOSS0369 has embarked on their Quest. 🗡

  • @THEBOSS0369 has been on GitHub since 2023.
  • They have merged 20 public PRs in that time.
  • Their swords are blessed with Shell and Python magic ✨
  • They have contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

Copy link

quest-bot bot commented Oct 26, 2024

🧚 @THEBOSS0369 has submitted PR #2164 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

Questions? Check out the docs.

@THEBOSS0369
Copy link
Contributor

Hey Everyone ! I have created a PR for this issue #2164 . Please review it and give the feedback. Thanks!

FredLL-Avaiga added a commit to THEBOSS0369/taipy that referenced this issue Oct 28, 2024
THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Oct 29, 2024
@FredLL-Avaiga
Copy link
Member

FredLL-Avaiga commented Oct 29, 2024

Are we supposed to support json edition in this issue ? @FlorianJacta @jrobinAV @EYisaac ?

THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Oct 30, 2024
FredLL-Avaiga added a commit to THEBOSS0369/taipy that referenced this issue Oct 30, 2024
THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Oct 31, 2024
@jrobinAV
Copy link
Member

jrobinAV commented Oct 31, 2024

Are we supposed to support json edition in this issue ? @FlorianJacta @jrobinAV @EYisaac ?

@FredLL-Avaiga
Being able to edit the JSON data is part of the issue, yes.

However, if it is too complex at first, we can split it into two issues and start with the reading part only. But we should at least keep in mind that editing the data will, in the end, be part of it.

FredLL-Avaiga added a commit to THEBOSS0369/taipy that referenced this issue Oct 31, 2024
@FredLL-Avaiga
Copy link
Member

the chosen frontend package allows for editing.
So we'll be good when we decide to implement that feature.
Would you mind creating another issue for that purpose @jrobinAV ?

THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Nov 1, 2024
FredLL-Avaiga added a commit to THEBOSS0369/taipy that referenced this issue Nov 2, 2024
THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Nov 3, 2024
THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Nov 4, 2024
THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Nov 4, 2024
THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Nov 4, 2024
THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Nov 5, 2024
THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Nov 6, 2024
@jrobinAV
Copy link
Member

jrobinAV commented Nov 7, 2024

@FredLL-Avaiga SOunds fair. Let me create another ticket.

@EYisaac Do not hesitate to get back to us with more details on your edition needs, if ever.

THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Nov 7, 2024
THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Nov 7, 2024
FredLL-Avaiga added a commit to THEBOSS0369/taipy that referenced this issue Nov 8, 2024
FredLL-Avaiga added a commit to THEBOSS0369/taipy that referenced this issue Nov 8, 2024
THEBOSS0369 added a commit to THEBOSS0369/taipy that referenced this issue Nov 8, 2024
FredLL-Avaiga added a commit to THEBOSS0369/taipy that referenced this issue Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Related to Taipy Core 🖰 GUI Related to GUI hacktoberfest - 300💎💎💎 Issues rewarded by 300 points hacktoberfest hacktoberfest issues 🆘 Help wanted Open to participation from the community ✨New feature 🟨 Priority: Medium Not blocking but should be addressed ⚔️ Quest Tracks quest-bot quests
Projects
None yet
6 participants