Feat/switch light theme #609
Conversation
gregmartDOTin
requested review from
jordan-a-young and
LauRoxx
as code owners
|
| @@ -12,6 +17,29 @@ export type SwitchProps = Omit< | |||
| | 'touchRippleRef' | |||
| >; | |||
|
|
|||
| export const Switch = (args: SwitchProps): JSX.Element => { | |||
| const CheckedIconSwitch = styled(MuiSwitch)(({ theme }) => ({ | |||
There was a problem hiding this comment.
do we also want to fix this for legacy theme?
There was a problem hiding this comment.
Oh, yeah, good call. I'll fix it.
| args: { | ||
| sx: { marginRight: '6px' }, | ||
| inputProps: { | ||
| 'aria-label': 'example', |
There was a problem hiding this comment.
Personally, I prefer the bare component with no label for the primary story, but if we're keeping FormControlLabel let's ditch the aria-label
There was a problem hiding this comment.
I had a conversation with UX about this. The pattern in zeroheight expects an action label, so this would be the most common use case.
There was a problem hiding this comment.
but the primary story isn't related to use case, it's the component itself... i think UX is misunderstanding that dev docs are different than their use cases.
There was a problem hiding this comment.
That makes sense. I switched back to the Switch story being a bare Switch component and added the With Label story.
No description provided.