Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag adorner fixes. #172

Merged
merged 3 commits into from
May 11, 2023
Merged

Drag adorner fixes. #172

merged 3 commits into from
May 11, 2023

Conversation

grokys
Copy link
Member

@grokys grokys commented Apr 27, 2023

  • Drag adorner was sometimes not showing for a row. I couldn't get this to happen in a reproducible manner on my machine, but there seems to be a problem with Adorners on Avalonia 11 (maybe Broken Adorner Layer Invalidation or Clipping Avalonia#10701?). This PR tries a different approach and adorns the TreeDataGrid itself instead of the TreeDatGridRow which seems to be better
  • Hide drag adorner after a delay: The DragLeave event gets fired before the DragEnter event for the new control, which caused flickering. Might be an Avalonia bug, though it also looks like WPF has this behavior so maybe not. Hide the drag adorner after a small delay to work around this.

There seems to be some sort of problem with adorners (possibly AvaloniaUI/Avalonia#10701), I'm hoping this will fix it.
The `DragLeave` event gets fired before the `DragEnter` event for the new control, which caused flickering. Might be an Avalonia bug, though it also looks like WPF has this behavior so maybe not. Hide the drag adorner after a small delay to work around this.
@maxkatz6 maxkatz6 enabled auto-merge April 27, 2023 23:04
@grokys grokys disabled auto-merge May 11, 2023 11:55
@grokys grokys enabled auto-merge May 11, 2023 11:55
@grokys grokys disabled auto-merge May 11, 2023 12:11
@grokys grokys merged commit f55b2b0 into master May 11, 2023
@grokys grokys deleted the fixes/drag-adorner branch May 11, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants