Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 11.0.0-rc1.1 #183

Merged
merged 15 commits into from
Jun 2, 2023
Merged

Update to 11.0.0-rc1.1 #183

merged 15 commits into from
Jun 2, 2023

Conversation

wieslawsoltes
Copy link
Contributor

No description provided.

@maxkatz6
Copy link
Member

I guess SingleSubscriberObservableBase should be copypasted to this repo as internal

@wieslawsoltes
Copy link
Contributor Author

I guess SingleSubscriberObservableBase should be copypasted to this repo as internal

done

@wieslawsoltes wieslawsoltes marked this pull request as ready for review May 31, 2023 20:49
@wieslawsoltes wieslawsoltes changed the title Update to RC Update to RC1 May 31, 2023
@wieslawsoltes wieslawsoltes changed the title Update to RC1 Update to 11.0.0-rc1.1 May 31, 2023
maxkatz6 and others added 5 commits June 1, 2023 16:09
@maxkatz6
Use Avalonia tests everywhere to avoid issue with Dispatcher
291e9c7
@grokys
Fix failing test.
c751748 
Both root items are now realized before expanding the root note now, so reset the `instantiations` before expanding and take into account that the root node has already been realized.
@grokys
Fix failing test.
0149c46 
There is now no difference between the layout of the first cell and the rest of the cells.
@grokys
We don't need a xaml file for TestApplication.
6c03e24
@grokys
Make alternating background transparent gray.
46b394b 
Looks OK with both light and dark themes.
@grokys grokys merged commit 2fdcfc8 into master Jun 2, 2023
@grokys grokys deleted the UpdateToRc branch June 2, 2023 14:10
@schnerring
Copy link

I'm currently trying to upgrade Avalonia from preview6 to rc1.1 but get this exception:

System.MissingMethodException: Method not found: 'Void Avalonia.Styling.StyleBase.Add(Avalonia.Styling.ISetter)'.
   at CompiledAvaloniaXaml.!AvaloniaResources.Populate:/Themes/Fluent.axaml(IServiceProvider, Styles)
   at CompiledAvaloniaXaml.!AvaloniaResources.Build:/Themes/Fluent.axaml(IServiceProvider) in /home/vsts/work/1/s/src/Avalonia.Controls.TreeDataGrid/Themes/Fluent.axaml:line 1

My guess is that this PR fixes the above exception and that I'll have to wait for the next TreeDataGrid NuGet release. But I can't really say because the changes of this PR go a bit over my head.

Or is this another issue?

@Numpsy
Copy link

Numpsy commented Jun 8, 2023 •
edited
Loading

I'm currently trying to upgrade Avalonia from preview6 to rc1.1 but get this exception:

Hi,

I was just going to ask if there will be an RC1 TreeDataGrid nuget package published, as the most recent one I see on nuget.org is the 11.0.0-preview8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkatz6 maxkatz6 maxkatz6 approved these changes

@grokys grokys grokys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wieslawsoltes @maxkatz6 @schnerring @Numpsy @grokys