Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trimmability #302

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Trimmability #302

wants to merge 5 commits into from

Conversation

maxkatz6
Copy link
Member

  1. Adds .NET 6 and .NET 8 targets with corresponding Trimming and AOT warnings and attributes enabled.
  2. Removed usage of System.Reactive everywhere but kept in the public API. This way it is trimmed away, if not used by the developers.
  3. Makes sample project completely AOT friendly (CommunityToolkit + JSON source gen + compiled bindings).

There are some minor breaking changes in the Avalonia.Experimental.Data namespace, but it's not a documented user API at least. Apps that already use TreeDataGrid should be unaffected unless they used experimental APIs directly.

System.Linq.Expressions is still widely used in the project. We might want to avoid that in the future. It doesn't produce trimming warnings here at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxkatz6