This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Check for Control base type since IControl interface is removed #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldbeater
approved these changes
Dec 4, 2022
worldbeater
added
the
release
|
This is now 🚢 ed as 1.5.1 https://www.nuget.org/packages/XamlNameReferenceGenerator/1.5.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avalonia.Controls.IControlinterface is removed with AvaloniaUI/Avalonia#9553. This causes generator to find no views, therefore it doesn't generate any source code.This PR adds a check for
Avalonia.Controls.Controlbase type since it will be used from now on. I didn't remove the interface check so previous versions of Avalonia should still work correctly. Fixes #99