Fix AutomationProperties.HelpText on macos (#17046)

* fix Automation.HelpText on windows * fix AutomationProperties.HelpText on macos * change breaking abstract to virtual * only fall back to tooltip if string * remove duplicate override * fix AutomationProperties.HelpText on macos
AvaloniaUI · Sep 24, 2024 · 05389af · 05389af
1 parent e2a07cc
commit 05389af
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/native/Avalonia.Native/src/OSX/automation.mm b/native/Avalonia.Native/src/OSX/automation.mm
@@ -149,6 +149,11 @@ - (NSString *)accessibilityTitle
     return [super accessibilityTitle];
 }
 
+- (NSString *)accessibilityHelp
+{
+    return GetNSStringAndRelease(_peer->GetHelpText()); 
+}
+
 - (id)accessibilityValue
 {
     if (_peer->IsRangeValueProvider())

diff --git a/src/Avalonia.Native/AvnAutomationPeer.cs b/src/Avalonia.Native/AvnAutomationPeer.cs
@@ -39,6 +39,7 @@ private AvnAutomationPeer(AutomationPeer inner)
         public IAvnString ClassName => _inner.GetClassName().ToAvnString();
         public IAvnAutomationPeer? LabeledBy => Wrap(_inner.GetLabeledBy());
         public IAvnString Name => _inner.GetName().ToAvnString();
+        public IAvnString HelpText => _inner.GetHelpText().ToAvnString();
         public IAvnAutomationPeer? Parent => Wrap(_inner.GetParent());
         public IAvnAutomationPeer? VisualRoot => Wrap(_inner.GetVisualRoot());
 

diff --git a/src/Avalonia.Native/avn.idl b/src/Avalonia.Native/avn.idl
@@ -1219,6 +1219,8 @@ interface IAvnAutomationPeer : IUnknown
      bool IsValueProvider();
      IAvnString* ValueProvider_GetValue();
      void ValueProvider_SetValue(char* value);
+
+     IAvnString* GetHelpText();
 }
 
 [uuid(b00af5da-78af-4b33-bfff-4ce13a6239a9)]