Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly signing #5939

Open
derekantrican opened this issue May 18, 2021 · 30 comments
Open

Assembly signing #5939

derekantrican opened this issue May 18, 2021 · 30 comments

Comments

@derekantrican
Copy link
Contributor

In the wake of #5937 and #5938, a lot of users of Avalonia-built applications were seeing Windows Defender block those applications. Windows Defender claimed to have found a Trojan and as a "Severe" classification, deleted the assemblies. This resulted in a number of users being unable to launch the application until they somehow re-downloaded that assembly (usually by reinstalling the application).

The real solution is to sign the Avalonia assemblies.

@kekekeks
Copy link
Member

We are currently choosing the authenticode certificate provider and investigating how to integrate signing to our build pipeline.

@sn4k3
Copy link
Contributor

sn4k3 commented May 18, 2021

Also getting problems on the Avalonia.Themes.Default.dll

image

@derekantrican
Copy link
Contributor Author

@sn4k3 see #5937 (comment) that is for the Windows Defender issues

@derekantrican
Copy link
Contributor Author

@kekekeks is Avalonia possibly using the /p:PublishTrimmed=true flag? dotnet/runtime#33745

@kekekeks
Copy link
Member

No, we are not.

@batzen
Copy link

batzen commented Jun 12, 2021

You could ask SignPath. They offer an authenticode signing service for OSS projects. Maybe @matkoch from JetBrains can help you on that as they are using Avalionia. He also helped me getting started with SignPath for Snoop.

@matkoch
Copy link
Contributor

matkoch commented Jun 12, 2021

Yep, let me know when you're interested.

@kekekeks
Copy link
Member

Yes, it would be nice to get SignPath, since we got stuck with Sectigo for some reason.

@josephnarai

This comment was marked as off-topic.

@beto-rodriguez
Copy link

beto-rodriguez commented Dec 4, 2021

Avalonia assemblies seems to be signed, at least the Avalonia.Desktop assembly is, @kekekeks so this means that signing an assembly where the certificate is not provided by a trusted authority will cause this issue? for any assembly?

@josephnarai
Copy link

josephnarai commented Dec 4, 2021 via email

@kekekeks
Copy link
Member

kekekeks commented Dec 4, 2021

There is a difference between strong name signing (that uses just a private key which can even be published if needed) and Authenticode signing (that requires a certificate provided by some authority). In case of @josephnarai it seems that provided strong name signing key file is incompatible with Mono.Cecil.

@josephnarai

This comment was marked as off-topic.

@darinkes
Copy link

Hi,

Whats the current status regarding Authenticode Signatures for Avalonia DLLs?
Seems there are a lot of AntiVir/Security Suites out there, which block usage of unsigned DLLs.

Thanks in advance

@rprimora-pricer

This comment was marked as off-topic.

@maxkatz6

This comment was marked as off-topic.

@rprimora-pricer

This comment was marked as off-topic.

@sn4k3

This comment was marked as off-topic.

@rprimora-pricer

This comment was marked as off-topic.

@maxkatz6

This comment was marked as off-topic.

@rprimora-pricer

This comment was marked as off-topic.

@workgroupengineering

This comment was marked as off-topic.

@rprimora-pricer

This comment was marked as off-topic.

@workgroupengineering

This comment was marked as off-topic.

@rprimora-pricer

This comment was marked as off-topic.

@maxkatz6

This comment was marked as off-topic.

@rprimora-pricer
Copy link

Who/what is Cecil?

By the way, I pondered the idea of faulty environment but this error is also thrown in Azure Pipelines where I use msbuild.

@maxkatz6
Copy link
Member

maxkatz6 commented Oct 27, 2023

Cecil is a dependency that processes assemblies during XAML compilation.
Btw, please open a new issue with minimal repro, as yours and josephnarai issue isn't related to authenticode signing discussed in this topic.

@ThomasNieto
Copy link

@kekekeks is there any update on getting the assemblies authenticode signed? If no cert has been provisioned yet I'd recommend applying for a SignPath OSS cert.

@henrygab
Copy link

Assemblies still lack authenticode signatures ... more than three and a half years later.
@kekekeks ... Can you help folks understand what might be preventing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests