-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AvaloniaList compile time parsing #11073
Conversation
You can test this PR using the following package version. |
I wonder if it makes sense to parse into |
@kekekeks done, also kekekeks/XamlX#86 |
public Polyline() | ||
{ | ||
Points = new Points(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR, but changes nullability of points property to be consistent with PolyLineSegment/Geometry.
You can test this PR using the following package version. |
Not a huge fan of going from a clear |
What does the pull request do?
Instead of relying on runtime parsing which would bring unsafe AvaloniaListConverter (because of TypeConverters with reflection), attempt to do it compile time for prepared types.
Initially I added this attribute for Classes property, which doesn't use ',' as a separator and ' ' is instead, but @grokys already has redone how Classes are parsed in compile time and it has a way more specific logic now.
This attribute can be removed now, if we define "," as a separator for all AvaloniaLists and not just default.
Fixed issues
Fixes #10109