Fix for Win32Platform ArgumentException when creating WindowIcon from Bitmap #14550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
The PR fixes the issue #14541, by extending the Win32Platform correction already provided in this PR.
The other relevant implementations of IPlatformIconLoader in Avalonia.X11.X11IconLoader and Avalonia.Native.IconLoader implement the logic correctly, thus are not affected by the issue.
What is the current behavior?
The Win32Platform implementation of IWindowIconImpl LoadIcon(IBitmapImpl bitmap) throws an ArgumentException.
What is the updated/expected behavior with this PR?
The Win32Platform implementation of IWindowIconImpl LoadIcon(IBitmapImpl bitmap) does not throw an ArgumentException anymore.
How was the solution implemented?
The fix calls the method IconImpl CreateIconImpl(Stream stream), just like the other two LoadIcon() methods in the class Win32Platform.
Fixed issues
Fixes #14541