Fix popups position on X11 #14551
Merged
Fix popups position on X11 #14551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mary Guillemard <mary@mary.zone>
…X11Window.Position 567561e caused the origin of window to not be (0, 0) for popups on X. As a result, all popups were wrongly positioned. This change Position to translate from root window coordinates (the display space) to parent window coordinates. Signed-off-by: Mary Guillemard <mary@mary.zone>
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
No worries.
We are going to release 11.0.9 soon, as there is another critical due to incorrectly backported PR.
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Feb 9, 2024
* Ensure to use the appropriate parent when talking with X11 in X11Window Signed-off-by: Mary Guillemard <mary@mary.zone> * Translate root window coordinates to window coordinates when setting X11Window.Position 567561e caused the origin of window to not be (0, 0) for popups on X. As a result, all popups were wrongly positioned. This change Position to translate from root window coordinates (the display space) to parent window coordinates. Signed-off-by: Mary Guillemard <mary@mary.zone> --------- Signed-off-by: Mary Guillemard <mary@mary.zone>
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
|
Setting popup window parent makes it to be constrained to the window. Which is not desired behavior. So both PRs will be reverted as regressions. |
kekekeks
added a commit
that referenced
this pull request
Feb 10, 2024
kekekeks
added a commit
that referenced
this pull request
Feb 10, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Feb 14, 2024
amurgshere
pushed a commit
to amurgshere/Ryujinx
that referenced
this pull request
Oct 2, 2024
This reverts commit dfc0819. X popup position broke entirely (my fault oops), waiting for next release with a fix (see AvaloniaUI/Avalonia#14551)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
567561e caused the origin of window to not be (0, 0) for popups on X.
As a result, all popups were wrongly positioned.
This change Position to translate from root window coordinates (the display space) to parent window coordinates.
I also changed every X calls to depends on the correct parent in X11Window.
This is a major regression in Avalonia 11.0.8, sorry about that. 😅
This time tested under KDE Plasma 5 and gamescope.