Fix incorrect usage of ComboBox in control catalog ViewboxPage #14972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Mar 14, 2024
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This pull request tries to fix the incorrect usage of
ComboBoxinViewboxPage.What is the current behavior?
The items of the
ComboBoxinViewboxPagedo not display as expected.What is the updated/expected behavior with this PR?
The
ArrayListshould be set toItemsSourceproperty instead of theContenton theComboBox.How was the solution implemented (if it's not obvious)?
Moved the
ArrayListinstances into theItemsSourceproperty.Checklist
Breaking changes
None.
Obsoletions / Deprecations
None.
Fixed issues
None.