Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't get the composition animation system involved in every property read #15110

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

kekekeks
Copy link
Member

@kekekeks kekekeks commented Mar 24, 2024

99.9% of our visuals aren't involved in composition animations, yet every single property read is reading from animation store dictionaries.

This PR:

  • extracts animation-related code into a separate auxiliary class
  • introduces a special step for updating effective animated values rather then trying to evaluate those on demand

So server object property reads are now simple field reads and are way faster

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0046515-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0046541-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@kekekeks kekekeks marked this pull request as ready for review March 25, 2024 07:02
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0046559-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 merged commit e79d62a into master Mar 25, 2024
11 checks passed
@maxkatz6 maxkatz6 deleted the feature/perf-2024-03-0003 branch March 25, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants