Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete API usage from SelectingItemsControl. #16220

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

grokys
Copy link
Member

@grokys grokys commented Jul 3, 2024

What does the pull request do?

Removes usage of the now obsolete IBinding.Initiate API from SelectingItemsControl and uses AvaloniaObject.Bind instead,

Also fixes an issue where _lastBinding was never used, meaning that previous bindings weren't disposed potentially causing a leak.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049772-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added enhancement backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Jul 3, 2024
@maxkatz6 maxkatz6 added this pull request to the merge queue Jul 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2024
@maxkatz6 maxkatz6 added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit 6ea50d9 Jul 3, 2024
12 checks passed
@maxkatz6 maxkatz6 deleted the fixes/selectingitemscontrol-obsolete-api branch July 3, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants