Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BaselineAlignment #16276

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Jul 10, 2024

What does the pull request do?

This PR adds support for all BaselineAlignment variants. Previously not all of them where handled.
This also fixes the baseline alignment for mixed typefaces that are layout in one line.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049994-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049998-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald Gillibald changed the title [WIP]Implement remaining BaselineAlignment variants Fix BaselineAlignment Jul 11, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050014-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050018-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added area-textprocessing backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Jul 12, 2024
@Gillibald Gillibald added this pull request to the merge queue Jul 15, 2024
Merged via the queue into AvaloniaUI:master with commit 376a841 Jul 15, 2024
11 checks passed
@Gillibald Gillibald deleted the fixes/baselineAlignment branch July 15, 2024 06:03
@kerams
Copy link

kerams commented Jul 16, 2024

This fixes my repro in #15984 (comment) - thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-textprocessing backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants