Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS WindowState call on Show crash fix #16341

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

jmacato
Copy link
Member

@jmacato jmacato commented Jul 16, 2024

Fixes an issue when an avalonia app calls close on a window on macOS while the window is still showing up.

cc @kekekeks

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050182-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added bug os-macos backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Jul 17, 2024
@maxkatz6 maxkatz6 requested a review from kekekeks July 17, 2024 02:49
Copy link
Member

@kekekeks kekekeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to wrap that into a property or smth, but lgtm

@jmacato jmacato enabled auto-merge July 17, 2024 04:24
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050212-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@jmacato jmacato disabled auto-merge July 17, 2024 10:07
@jmacato jmacato merged commit 945b371 into master Jul 17, 2024
9 of 11 checks passed
@jmacato jmacato deleted the fixes/macos-invalextmarg-winimpl-fix branch July 17, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch bug os-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants