Android - Defer rendering till surface is created #16616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
emmauss
force-pushed
the
android_fix_surface_creation
branch
from
5e92eb3
to
4518003
Compare
|
You can test this PR using the following package version. |
emmauss
force-pushed
the
android_fix_surface_creation
branch
from
4518003
to
f12cc8a
Compare
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes #16588 . For some reason, the Orientation and ScreenSize config change flags aren't being applied, even when set. This pr makes recreation of the activity safer, by deferring the start of the rendering session till after the view surface is created. This fixes issues where the app is started while the device is in a state where activities aren't visible, like in sleep/stand by, and when a config change forces the activity to be recreated, like in the linked pr.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #16588