Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screens api refactor mobile #16647

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Screens api refactor mobile #16647

merged 6 commits into from
Aug 13, 2024

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

Continues previous PR #15901 with adding screens support for mobile and browser platforms.

These APIs can be accessed via TopLevel.Screens, as per usual with desktop platforms.

Fixed issues

Fixes partially #16572

@maxkatz6
Copy link
Member Author

Android (simulator)

image

Browser:
image

Note, browser returns "landscape" orientation for my obviously portrait monitor. But that's how it is in the browser API:
image

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0051149-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Contributor

@emmauss emmauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked browser and android versions

@maxkatz6 maxkatz6 merged commit 37ba4ce into master Aug 13, 2024
11 checks passed
@maxkatz6 maxkatz6 deleted the screens-api-refactor-mobile branch August 13, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants