Android - Input Connection fixes #16666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2024
maxkatz6
approved these changes
Aug 13, 2024
MrJul
reviewed
Aug 13, 2024
| @@ -147,6 +147,26 @@ public bool PerformEditorAction([GeneratedEnum] ImeAction actionCode) | |||
| } | |||
| } | |||
|
|
|||
| var eventTime = SystemClock.UptimeMillis(); | |||
| SendKeyEvent(new KeyEvent(eventTime, | |||
There was a problem hiding this comment.
I'm not familiar enough with the Android IME, but shouldn't this only be done for ImeAction.Done?
There was a problem hiding this comment.
The previous behavior was done for all actions. We could limit it to only actions that expect the keyboard to be dismissed.
emmauss
force-pushed
the
android_ime_fixes
branch
from
2f1763d
to
587249f
Compare
|
You can test this PR using the following package version. |
3 tasks
emmauss
force-pushed
the
android_ime_fixes
branch
from
38654ce
to
3ef1b2f
Compare
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes two issues;
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #16655