Prevent AutoCompleteBox getting stuck in a state where it can't drop down. #17074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap everything in a `try`...`finally` block so that they get reset even on exception.
grokys
added
bug
customer-priority
MrJul
approved these changes
Sep 20, 2024
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
AutoCompleteBoxsometimes can get stuck in a state where it can't get dropped down. A customer reported this, giving the use case where they setIsDropDownOpen(via a binding) before they setItemsSource(also via a binding).This happens because
AutoCompleteBox.RefeshViewhas two state flags:_filterInActionand_cancelRequested. Usually these are reset when the method exits but in the case where there are no items, the method exits early leaving_filterInActionset to true.Wrap the whole thing in a
try...finallyblock to make sure the flags are always reset when the method exits, even if there are exceptions etc.Note: the diff is best viewed using the
Hide whitespaceoption on GitHub as the whole block has changed indentation.