Add missing Screen.Equals/GetHashCode overrides #17112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing overrides for
Equals(object)
andGetHashCode()
onScreen
.This has two purposes: first to fix some build warnings, and second to correct the screen equality behavior.
Before this PR,
Screen.Equals(Screen)
was delegating tobase.Equals(object)
. I think it was meant to call theEquals(object)
overridden in the derivedPlatformScreen
, but thebase
call make it non-virtual.Basically,
Equals(Screen)
was always equivalent toReferenceEquals()
and thus different fromEquals(object)
.Equals(object)
now callsEquals(Screen)
, which is overridden.Ideally, we should make
Screen
,Screen.Equals(Screen)
andScreen.GetHashCode()
abstract in v12.