Make UiThreadRenderTimer to calculate the next tick time based on expected FPS #17121
Conversation
kekekeks
force-pushed
the
feature/self-adjusting-ui-render-timer
branch
from
98e46a5 to
dcaceb1
Compare
| return !cancelled; | ||
| }, TimeSpan.FromSeconds(1.0 / FramesPerSecond), DispatcherPriority.UiThreadRender); | ||
| return Disposable.Create(() => cancelled = true); | ||
| _tick?.Invoke(tickedAt); |
There was a problem hiding this comment.
Nit: _tick is never null, ? can be removed.
| } | ||
|
|
||
| private static readonly TimeSpan s_minInterval = TimeSpan.FromMilliseconds(1); | ||
| private TimeSpan Interval => TimeSpan.FromSeconds(1.0 / _parent.FramesPerSecond); |
There was a problem hiding this comment.
Since FramesPerSecond can't change, the frame interval can probably be computed only once in the constructor.
|
You can test this PR using the following package version. |
kekekeks
added
enhancement
backport-candidate-11.1.x
|
|
|
|
|
@maxkatz6 OK, I did notice the PrivateApi attribute was removed here as well. |
|
You can test this PR using the following package version. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
DispatcherTimer.Interval indicates the interval between the previous tick completion and the next one. Render timer, on the other hand, needs to have its interval to indicate time between tick starts.