[SKIA] Don't re-create SKImage on every WriteableBitmap draw call #18164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekekeks
added
bug
backport-candidate-11.2.x
maxkatz6
approved these changes
Feb 10, 2025
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
maxkatz6
pushed a commit
that referenced
this pull request
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There previously was
SKCanvas::drawBitmapmethod, but it apparently got removed around 2021. That method was properly tracking SKBitmap pixel data versioning that we've been reporting via SKBitmap::notifyPixelsChanged, so a bitmap would only uploaded to GPU once per change if it would fit into gpu memory allowance.SkiaSharp have silently added a shim that would just re-create an SKImage instance on every draw call.
This PR caches an SKImage instance.
Note that it technically increases the system RAM usage.