Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove :valid and :invalid pseudoclasses. #2253

Merged
merged 3 commits into from
Jan 19, 2019

Conversation

grokys
Copy link
Member

@grokys grokys commented Jan 19, 2019

:valid and :invalid pseudoclasses are being added to all ContentControls simply in order to show/hide the ContentPresenter in CheckBox. Instead of this, add some ObjectConverters and use them to set the visibility of the ContentPresenter.

Breaking change: also renamed the converters in StringConverters to add an Is prefix as the ObjectConverters didn't look right as just ObjectConverters.Null and ObjectConverters.NotNull: ObjectConverters.IsNull and ObjectConverters.IsNotNull read better.

Fixes #1999

`:valid` and `:invalid` pseudoclasses are being added to all `ContentControls` simply in order to show/hide the `ContentPresenter` in `CheckBox`. Instead of this, add some `ObjectConverters` and use them to set the visibility of the `ContentPresenter.`

Also renamed the converters in `StringConverters` to add an `Is` prefix as the `ObjectConverters` didn't look right as just `Null` and `NotNull`.
@grokys grokys requested a review from a team January 19, 2019 00:53
@grokys grokys merged commit 418bd43 into master Jan 19, 2019
@grokys grokys deleted the fixes/1999-remove-valid-invalid-pseudoclasses branch January 19, 2019 16:57
@grokys grokys added this to the 0.8.0 milestone Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:valid pseudoclass is being applied to all ContentControls.
2 participants