Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OnPlatformExtension. #7812

Merged
merged 44 commits into from
Nov 11, 2022
Merged

Add OnPlatformExtension. #7812

merged 44 commits into from
Nov 11, 2022

Conversation

danwalmsley
Copy link
Member

@danwalmsley danwalmsley commented Mar 15, 2022 •
edited
Loading

What does the pull request do?

Implements OnPlatform and OnIdiom markup extensions as closely as can be implemented right now.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@maxkatz6 maxkatz6 changed the title Add service for runtime platform information. Add OnPlatformExtension. Jun 1, 2022
@maxkatz6 maxkatz6 self-assigned this Jun 19, 2022
@maxkatz6 maxkatz6 added this to the 11.0 milestone Jun 19, 2022
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0024996-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@danwalmsley danwalmsley marked this pull request as ready for review October 19, 2022 19:54
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0025075-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0025141-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0025511-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 force-pushed the feature/onplatform-xaml-compiler-support branch from a8f5d5c to f489a33 Compare November 10, 2022 21:05
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0026057-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0026064-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@danwalmsley danwalmsley merged commit cce7509 into master Nov 11, 2022
@danwalmsley danwalmsley deleted the feature/onplatform-xaml-compiler-support branch November 11, 2022 10:31
@timunie timunie mentioned this pull request Jul 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kekekeks kekekeks kekekeks requested changes

@maxkatz6 maxkatz6 maxkatz6 left review comments

Assignees

@maxkatz6 maxkatz6

Labels
feature
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@danwalmsley @avaloniaui-team @kekekeks @maxkatz6