Remove all obsolete members from Input namespace #8577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
commented
Jul 23, 2022
| @@ -302,9 +304,6 @@ public ILayoutManager LayoutManager | |||
| set { SetValue(PointerOverElementProperty, value); } | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| IMouseDevice? IInputRoot.MouseDevice => PlatformImpl?.MouseDevice; | |||
There was a problem hiding this comment.
MouseDevice wasn't obsolete here, but why would we keep it public?
There was a problem hiding this comment.
Its public members were removed, and it doesn't work with other input types.
maxkatz6
commented
Jul 23, 2022
| positionerParameters.Offset = offset; | ||
| positionerParameters.ConstraintAdjustment = constraintAdjustment; | ||
| if (placement == PlacementMode.Pointer) | ||
| { | ||
| positionerParameters.AnchorRectangle = new Rect(pointer, new Size(1, 1)); | ||
| // We need a better way for tracking the last pointer position | ||
| var position = topLevel.PointToClient(topLevel.LastPointerPosition ?? default); |
There was a problem hiding this comment.
I couldn't find a better idea, except keeping old property but internal.
I don't think we can really subscribe on popup's target' root pointer movements, as there might not be any movements between assigning the target and opening the popup.
|
You can test this PR using the following package version. |
kekekeks
approved these changes
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
Previously obsolete members were removed.
Fixed issues
Part of #3538