Remove IRuntimePlatform.OperatingSystem API and replace with trimmable OperatingSystem API #9760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
hez2010
suggested changes
Dec 23, 2022
hez2010
suggested changes
Dec 23, 2022
kekekeks
approved these changes
Dec 23, 2022
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Before this PR we used IRuntimePlatform.OperatingSystem which was too complex for the compiler to analyze and trim.
What is the updated/expected behavior with this PR?
With this PR OperatingSystem API is used, and when developers build project with specific runtime identifier (win7-x64, linux-x64...) or target framework, unused code will be removed from the assembly, including whole dependency assemblies.
It is especially useful with
Avalonia.Desktoppackage, which previously references platform specific packages for all three main platforms. Even though it was actually loading into the memory only one of them previously, and it was possible to safely remove others, now it will do it automatically.Also makes OnPlatform to use OperatingSystem which also improves generated and trimmed code. (CC @robloo in context of #1434).
Keep in mind that if DataGrid usage can be trimmed-out from the OnPlatform branches, but assembly is still likely to be referenced, as we include its styles in the App.xaml. Alternatively, styles might be included inside of the OnPlatform branch, but I did not try this.
Breaking changes
Yes, IRuntimePlatform.GetRuntimeInfo() interface has lost most of its properties. This API ideally should have been replaced with RuntimeInformation or OperatingSystem standard BCL APIs long time ago.